Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require that imported functions must be Send #1161

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Require that imported functions must be Send #1161

merged 2 commits into from
Jan 21, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Jan 17, 2020 •
edited
Loading

resolves #1074

Review

  • Add a short description of the the change to the CHANGELOG.md file

@MarkMcCaskey MarkMcCaskey added bug Something isn't working 🔈soundness Bugs causing an unsound API labels Jan 17, 2020
@MarkMcCaskey MarkMcCaskey force-pushed the fix/imported-functions-must-be-send branch from 946cb92 to 8c760da Compare January 17, 2020 23:14
@Hywan Hywan self-assigned this Jan 20, 2020
@Hywan Hywan added the 📦 lib-deprecated About the deprecated crates label Jan 20, 2020
Hywan
Hywan approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it is OK. Yes it is a breaking change, but it is required. Also, I'm not sure it will impact most users.

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 20, 2020

This PR was included in a batch with a merge conflict, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented Jan 20, 2020

Merge conflict

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jan 21, 2020
@bors @MarkMcCaskey
Merge #1161
b73f261 
1161: Require that imported functions must be `Send` r=MarkMcCaskey a=MarkMcCaskey

resolves #1074 

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <5770194+MarkMcCaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jan 21, 2020

Build succeeded

@bors bors bot merged commit f1db4ae into master Jan 21, 2020
@bors bors bot deleted the fix/imported-functions-must-be-send branch January 21, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@bjfish bjfish Awaiting requested review from bjfish

Assignees

@Hywan Hywan

Labels
bug Something isn't working 📦 lib-deprecated About the deprecated crates 🔈soundness Bugs causing an unsound API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instance is Send even if it contains !Send host functions
2 participants
@MarkMcCaskey @Hywan