Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ExceptionCode for error representation. #1192

Merged
merged 7 commits into from
Feb 11, 2020
Merged

Use ExceptionCode for error representation. #1192

merged 7 commits into from
Feb 11, 2020

Conversation

losfair
Copy link
Contributor

@losfair losfair commented Feb 6, 2020

Extends #1129 to all backends.

@losfair
Copy link
Contributor Author

losfair commented Feb 6, 2020

bors try

bors bot added a commit that referenced this pull request Feb 6, 2020
@bors
Try #1192:
0a8a470
@bors
Copy link
Contributor

bors bot commented Feb 6, 2020

try

Build failed

bors bot added a commit that referenced this pull request Feb 10, 2020
@bors @losfair
Merge #1192
ab059ff 
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair

Extends #1129 to all backends.

Co-authored-by: losfair <zhy20000919@hotmail.com>
bors bot added a commit that referenced this pull request Feb 10, 2020
@bors @losfair
Merge #1192
004dadc 
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair

Extends #1129 to all backends.

Co-authored-by: losfair <zhy20000919@hotmail.com>
@wasmerio wasmerio deleted a comment from bors bot Feb 10, 2020
@losfair
Copy link
Contributor Author

losfair commented Feb 10, 2020

bors r+

@wasmerio wasmerio deleted a comment from bors bot Feb 10, 2020
bors bot added a commit that referenced this pull request Feb 10, 2020
@bors @losfair
Merge #1192
92f2628 
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair

Extends #1129 to all backends.

Co-authored-by: losfair <zhy20000919@hotmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 10, 2020

Build failed

  • wasmerio.wasmer

@losfair
Copy link
Contributor Author

losfair commented Feb 11, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 11, 2020
@bors @losfair
Merge #1192
eaa081e 
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair

Extends #1129 to all backends.

Co-authored-by: losfair <zhy20000919@hotmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 11, 2020

Build succeeded

@bors bors bot merged commit 3999728 into master Feb 11, 2020
@bors bors bot deleted the feature/remove-wasm-trap-info branch February 11, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewycky nlewycky nlewycky approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@losfair @nlewycky