Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interface-types) Implement the WAT decoder #1232

Merged
merged 11 commits into from
Feb 21, 2020
Merged

feat(interface-types) Implement the WAT decoder #1232

merged 11 commits into from
Feb 21, 2020

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Feb 19, 2020

WIP

The goal is the define a minimal WAT to AST decoder for WIT, so that it's muuuuuuch easier to develop and debug.

@Hywan
Copy link
Contributor Author

Hywan commented Feb 20, 2020

Almost there! A public API is missing, and documentation of course.

@Hywan Hywan marked this pull request as ready for review February 20, 2020 18:34
MarkMcCaskey
MarkMcCaskey approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me! I didn't notice anything that could be improved -- checked the docs for wast too and didn't see anything there that I thought you could use to improve it

@syrusakbary

This comment has been minimized.

Sign in to view
@Hywan
Copy link
Contributor Author

Hywan commented Feb 21, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 21, 2020
@bors @Hywan
Merge #1232
39a5045 
1232: feat(interface-types) Implement the WAT decoder r=Hywan a=Hywan

WIP

The goal is the define a minimal WAT to AST decoder for WIT, so that it's muuuuuuch easier to develop and debug.

Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
@Hywan
Copy link
Contributor Author

Hywan commented Feb 21, 2020

bors r-

@bors
Copy link
Contributor

bors bot commented Feb 21, 2020

Canceled

@Hywan
Copy link
Contributor Author

Hywan commented Feb 21, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 21, 2020

Build succeeded

@bors bors bot merged commit a96c436 into wasmerio:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
📚 documentation Do you like to read? 🎉 enhancement New feature! 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hywan @syrusakbary @MarkMcCaskey