Revert change of Ubuntu 18.04 to 16.04 #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't document why I changed it to 18.04 in #1163 ; making this PR to run CI and find out why.
It looks like CI is passing! I have no idea why I updated to 18.04. Perhaps I misread the support table and thought 16.04 no longer had standard support.
Either way, this PR seems good to merge.
This PR will fix wapm-cli's CI which can't run Wasmer 0.14.0 on Ubuntu 16.04 due to a GLIBC version issue:
/home/vsts/.wasmer/bin/wasmer: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /home/vsts/.wasmer/bin/wasmer)Review