Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move spectests to their own library #131

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Move spectests to their own library #131

merged 3 commits into from
Jan 30, 2019

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Jan 29, 2019

  • Removes wabt dependency from runtime-core

lachlansneff
lachlansneff approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM

Let's get the conflicts fixed and then merge.

@syrusakbary syrusakbary merged commit da9e323 into master Jan 30, 2019
@syrusakbary syrusakbary deleted the feature/move-spectests-to-own-lib branch February 6, 2019 23:13
nlewycky pushed a commit that referenced this pull request Aug 13, 2020
@syrusakbary
Merge pull request #144 from wasmerio/feat-cherry-picked
df9fcf3 
Cherry-picked from #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlansneff lachlansneff lachlansneff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjfish @lachlansneff @syrusakbary