Fix signature index issue #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Feb 7, 2019
bjfish
suggested changes
Feb 7, 2019
xmclark
reviewed
Feb 7, 2019
| panic!("invalid memory access, way out of bounds") | ||
| RuntimeError::OutOfBoundsAccess { | ||
| memory: MemoryIndex::new(0), | ||
| addr: 0, |
There was a problem hiding this comment.
this is slightly unrelated, but still good 👍
xmclark
approved these changes
Feb 7, 2019
| @@ -113,7 +113,7 @@ impl Instance { | |||
| .func_assoc | |||
| .get(*func_index) | |||
| .expect("broken invariant, incorrect func index"); | |||
| let signature = SigRegistry.lookup_signature(sig_index); | |||
| let signature = &self.module.info.signatures[sig_index]; | |||
bjfish
approved these changes
Feb 7, 2019
bors bot
added a commit
that referenced
this pull request
Sep 12, 2019
720: Bump lazy_static from 1.3.0 to 1.4.0 r=Hywan a=dependabot-preview[bot] Bumps [lazy_static](https://github.com/rust-lang-nursery/lazy-static.rs) from 1.3.0 to 1.4.0. <details> <summary>Release notes</summary> *Sourced from [lazy_static's releases](https://github.com/rust-lang-nursery/lazy-static.rs/releases).* > ## 1.4.0 > **Bumps the minimum supported version of `rustc` to `1.27.2`** > > - [Fix typo in lib.rs](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/pull/144) (thanks [@​fbruetting](https://github.com/fbruetting)) > - [Automatically check if README.md examples are working when running "cargo test"](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/pull/145) (thanks [@​GuillaumeGomez](https://github.com/GuillaumeGomez)) > - [Allow deprecated to remove warnings in nightly](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/pull/152) (thanks [@​Schaeff](https://github.com/Schaeff)) > - [bump MSRV to 1.27.2](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/pull/155) (thanks [@​matklad](https://github.com/matklad)) </details> <details> <summary>Commits</summary> - [`4216696`](rust-lang-nursery/lazy-static.rs@4216696) Merge pull request [#156](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/issues/156) from rust-lang-nursery/cargo/1.4.0 - [`1651fde`](rust-lang-nursery/lazy-static.rs@1651fde) prepare for 1.4.0 release - [`d9c9689`](rust-lang-nursery/lazy-static.rs@d9c9689) Merge pull request [#155](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/issues/155) from matklad/hints - [`d59c784`](rust-lang-nursery/lazy-static.rs@d59c784) adjust FIXME comment - [`90baadd`](rust-lang-nursery/lazy-static.rs@90baadd) comment typo - [`42fa58e`](rust-lang-nursery/lazy-static.rs@42fa58e) bump MSRV to 1.27.2 - [`8a5f404`](rust-lang-nursery/lazy-static.rs@8a5f404) Merge pull request [#152](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/issues/152) from Schaeff/allow-deprecated - [`1dbd5ae`](rust-lang-nursery/lazy-static.rs@1dbd5ae) allow deprecated to remove warning in nightly - [`65d58f1`](rust-lang-nursery/lazy-static.rs@65d58f1) Merge pull request [#145](https://github-redirect.dependabot.com/rust-lang-nursery/lazy-static.rs/issues/145) from GuillaumeGomez/doc-tests - [`e519fd4`](rust-lang-nursery/lazy-static.rs@e519fd4) Automatically check if README.md examples are working when running "cargo test" - Additional commits viewable in [compare view](rust-lang-nursery/lazy-static.rs@1.3.0...1.4.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=lazy_static&package-manager=cargo&previous-version=1.3.0&new-version=1.4.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- **Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit. You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com). <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> 765: Bump blake2b_simd from 0.5.7 to 0.5.8 r=Hywan a=dependabot-preview[bot] Bumps [blake2b_simd](https://github.com/oconnor663/blake2_simd) from 0.5.7 to 0.5.8. <details> <summary>Commits</summary> - [`296d75e`](oconnor663/blake2_simd@296d75e) version 0.5.8 - [`3706393`](oconnor663/blake2_simd@3706393) Merge pull request [#12](https://github-redirect.dependabot.com/oconnor663/blake2_simd/issues/12) from kobigurk/master - [`1ee274d`](oconnor663/blake2_simd@1ee274d) Addresses Jack's comments - [`ec7c0fc`](oconnor663/blake2_simd@ec7c0fc) Adds test vectors for blake2x - [`2bcd7bf`](oconnor663/blake2_simd@2bcd7bf) Adds support for max depth 0 for blake2b and fixes tests - [`0ce1995`](oconnor663/blake2_simd@0ce1995) adds support for max depth 0 - See full diff in [compare view](oconnor663/blake2_simd@0.5.7...0.5.8) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=blake2b_simd&package-manager=cargo&previous-version=0.5.7&new-version=0.5.8) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
nlewycky
pushed a commit
that referenced
this pull request
Aug 13, 2020
Fix a couple bugs with floats in compiler-llvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed an emscripten regression.