Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the SIGINT handler conditional on --features "managed". #1552

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Make the SIGINT handler conditional on --features "managed". #1552

merged 3 commits into from
Aug 19, 2020

Conversation

nlewycky
Copy link
Contributor

The SIGINT handler was used in the tier switching demo to switch between compiler tiers upon press of ^C in the terminal.

@nlewycky
Make the SIGINT handler conditional on --features "managed".
673910b 
The SIGINT handler was used in the tier switching demo to switch between compiler tiers upon press of ^C in the terminal.
@nlewycky nlewycky changed the base branch from master to 0.x August 18, 2020 22:54
@nlewycky nlewycky requested a review from Hywan as a code owner August 18, 2020 22:54
MarkMcCaskey
MarkMcCaskey approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nlewycky
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Aug 18, 2020
@bors @nlewycky
Merge #1552
b3e48cf 
1552: Make the SIGINT handler conditional on --features "managed". r=nlewycky a=nlewycky

The SIGINT handler was used in the tier switching demo to switch between compiler tiers upon press of ^C in the terminal.


Co-authored-by: Nick Lewycky <nicholas@mxc.ca>
@bors
Copy link
Contributor

bors bot commented Aug 18, 2020

Build failed:

  • wasmerio.wasmer

@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 19, 2020

Build succeeded:

  • wasmerio.wasmer

@bors bors bot merged commit f83cfbe into 0.x Aug 19, 2020
@bors bors bot deleted the feature/0.x-nosigint branch August 19, 2020 01:27
@nlewycky nlewycky mentioned this pull request Aug 19, 2020
Closed
1 task
@yun-yeo yun-yeo mentioned this pull request Nov 30, 2020
Closed
9 tasks
@matklad matklad mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlewycky @MarkMcCaskey