feat(c-api) Correctly implement “trap” in wasm_func_new*
#1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of “trap” in `wasm_func_new` was “incorrect”. It's more idiomatic to return a `RuntimeError` than raising it in this case, so that we don't duplicate locations where runtime errors are raised. The implementation of “trap” in `wasm_func_new_with_env` was missing. This patch implements a similar strategy than the sibling function.
Hywan
added
bug
Hywan
added a commit
to Hywan/go-ext-wasm
that referenced
this pull request
Oct 22, 2020
This custom build includes wasmerio/wasmer#1751.
jubianchi
approved these changes
Oct 22, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of “trap” in
wasm_func_newwas “incorrect”. It'smore idiomatic to return a
RuntimeErrorthan raising it in thiscase, so that we don't duplicate locations where runtime errors are
raised.
The implementation of “trap” in
wasm_func_new_with_envwasmissing. This patch implements a similar strategy than the sibling
function.
Fixes #1744.