WIP attempt to make an Export wrapper type #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't figure out how we can ever use the non-wrapped type though
MarkMcCaskey
requested review from
Hywan,
jubianchi and
nlewycky
as code owners
syrusakbary
reviewed
Nov 25, 2020
syrusakbary
reviewed
Nov 25, 2020
syrusakbary
reviewed
Nov 25, 2020
|
This PR will break as soon as #1837 is merged :-). |
|
Next steps:
struct FunctionExport {
vm_function: VMFunctionExport
ptr_...:
}
struct MemoryExport {
vm_memory: VMMemoryExport
}
... |
|
bors try |
syrusakbary
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback on that PR, creating a wrapper type for
ExportFunction: in order to make it more clear which is which, I also made anEngineExportand followed the code to where that needed to live... it seems that we'll just end up replacing all uses ofExportwithEngineExportin the API and that seemed wrong, looking for feedback here.