Remove cmake dependency #1880
Merged
Remove cmake dependency #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
requested review from
Hywan,
jubianchi and
MarkMcCaskey
as code owners
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try- |
|
bors try |
tryBuild failed: |
|
bors try |
syrusakbary
commented
Dec 5, 2020
Comment on lines
-221
to
+222
| ./target/release/wasmer compile --target=x86_64-apple-darwin tests/integration/cli/assets/qjs.wasm -o qjs_mac_from_linux.wjit | ||
| #./target/release/wasmer compile --target=x86_64-pc-windows-msvc tests/integration/cli/assets/qjs.wasm -o qjs_win_from_linux.wjit | ||
| ./target/release/wasmer compile --target=x86_64-apple-darwin lib/c-api/tests/assets/qjs.wasm -o qjs_mac_from_linux.wjit | ||
| #./target/release/wasmer compile --target=x86_64-pc-windows-msvc lib/c-api/tests/assets/qjs.wasm -o qjs_win_from_linux.wjit |
There was a problem hiding this comment.
Note: this change was done because the tests/integration/cli/assets/qjs.wasm was a symlink.
And once tested, as it was a existing file was quite hard to figure out what was going on.
Much easier to use directly the real files!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete cmake dependency (which is not yet available in macOS Big Sur with arm64 chipset).
This also simplifies the tests and make them run per compiler-engine tuple
Review