Add UnsupportedTarget error to compiler #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
requested review from
Hywan,
losfair,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
webmaster128
commented
Dec 6, 2020
lib/compiler/src/error.rs
Outdated
| /// The compiler cannot be used the current environment. | ||
| /// This can refer to the OS, the chipset or any other aspect of the environment the compiler runs in. | ||
| #[cfg_attr(feature = "std", error("Environment {0} is not yet supported (see https://docs.wasmer.io/ecosystem/wasmer/wasmer-features)"))] | ||
| UnsupportedEnvironment(String), |
There was a problem hiding this comment.
Maybe UnsupportedTarget should be the way to think about this?
There was a problem hiding this comment.
Yeah, I think UnsupportedTarget reflects much better the propose of the error!
There was a problem hiding this comment.
Also, it would be great to have the Target and Compiler name as part of the error!
Suggested change
| UnsupportedEnvironment(String), | |
| /// The compiler cannot be used the provided target. | |
| /// This can refer to the OS, the chipset or any other aspect of the environment the compiler runs in. | |
| #[cfg_attr(feature = "std", error("The target {0} is not yet supported in the compiler {1} (see https://docs.wasmer.io/ecosystem/wasmer/wasmer-features)"))] | |
| UnsupportedTarget(Target, Compiler), |
Note: we will need the Compiler trait to derive from Display (not just Send) and implement the Display trait for each of the compilers (CraneliftCompiler, LLVMCompiler and SinglepassCompiler).
There was a problem hiding this comment.
Updated to UnsupportedTarget and added tests. There is also an error for 32 bit now.
I'm not convinced about the proposed arguments:
- Using
Targetshows a lot of information to the user but does not provide information, which aspect of the target the problem is. - Adding
Compilerseems redundant to me. It puts some of the context information in the error message. But this context should be available by knowledge of the compiler or stack traces. Adding it to one error case only feels very inconsistent.
webmaster128
force-pushed
the
singlepass-windows-error
branch
from
372348d
to
624f0ec
Compare
webmaster128
changed the title
syrusakbary
approved these changes
Dec 7, 2020
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1878
Description
We can error early on for system combinations that are known to not work. This gives users a much better idea why things error and allows adapting the strategy without investing lots of time in debugging.
The different behaviour is tested here:
(CI job "Contract Development / Windows (pull_request)" in Upgrade to Wasmer Reborn (part 1) CosmWasm/cosmwasm#504)
(CI job "Contract Development / Windows (pull_request)" in Test Windows error CosmWasm/cosmwasm#648)
Something that is not yet clear to me is if
targetis the proper OS source information and if theCompilersupports cross compilation where compile evironment is different from runtime environment.Review