Remove to_wasm_error #1963
Merged
Remove to_wasm_error #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
requested review from
Hywan,
losfair,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
webmaster128
force-pushed
the
deprecate-to_wasm_error
branch
from
bb1da83
to
0d717aa
Compare
3 tasks
|
Let’s remove the |
|
Done |
bors bot
added a commit
that referenced
this pull request
Dec 22, 2020
1963: Deprecate to_wasm_error r=syrusakbary a=webmaster128 # Description This is a code style improvement that came up when working on #1962 but is independent of that. Should I remove `to_wasm_error` or keep it as deprecated? # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Simon Warta <simon@warta.it>
|
bors r+ |
|
Already running a review |
|
Build failed: |
webmaster128
force-pushed
the
deprecate-to_wasm_error
branch
from
8ac54f2
to
2f0e37d
Compare
|
Added two more commits at the end. Those should help with the compile error. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 22, 2020
1962: Reduce scope of wasmparser::BinaryReaderError in the codebase r=MarkMcCaskey a=webmaster128 ~Based on #1963~ Closes #1950 # Description There is an error conversion pileline `BinaryReaderError` -> `WasmError`. In this PR, the same conversion happens earlier, such that `WasmError`/`WasmResult` can be used in middlewares. Questions: - [ ] Should middlewares be allowed to produce all `WasmError` cases? Or should we introduce a `WasmError::MiddlewareError(String)`? - [x] ~Should `to_wasm_error` be removed as part of this PR?~ Extracted to #1963 # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Simon Warta <simon@warta.it>
bors bot
added a commit
that referenced
this pull request
Dec 22, 2020
1962: Reduce scope of wasmparser::BinaryReaderError in the codebase r=MarkMcCaskey a=webmaster128 ~Based on #1963~ Closes #1950 # Description There is an error conversion pileline `BinaryReaderError` -> `WasmError`. In this PR, the same conversion happens earlier, such that `WasmError`/`WasmResult` can be used in middlewares. Questions: - [ ] Should middlewares be allowed to produce all `WasmError` cases? Or should we introduce a `WasmError::MiddlewareError(String)`? - [x] ~Should `to_wasm_error` be removed as part of this PR?~ Extracted to #1963 # Review - [ ] Add a short description of the the change to the CHANGELOG.md file Co-authored-by: Simon Warta <simon@warta.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a code style improvement that came up when working on #1962 but is independent of that.
Should I remove
to_wasm_erroror keep it as deprecated?Review