Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c-api) Reduce the number of dependencies by statically compiling CRT #2140

Merged
merged 1 commit into from
Feb 26, 2021

Commits on Feb 25, 2021

  1. feat(c-api) Reduce the number of dependencies by statically compiling…

    … CRT.
    
    This patch adds the `-Ctarget-feature=+crt-static` flag when compiling
    `libwasmer` on Windows. The goal is twofold: Reducing the number of
    dependencies, and improving the portability of `libwasmer.dll` on more
    Windows instances.
    
    Before:
    
    ```sh
    $ objdump --all-headers wasmer.dll | rg 'DLL Name'
        DLL Name: bcrypt.dll
        DLL Name: ADVAPI32.dll
        DLL Name: KERNEL32.dll
        DLL Name: VCRUNTIME140.dll
        DLL Name: api-ms-win-crt-heap-l1-1-0.dll
        DLL Name: api-ms-win-crt-runtime-l1-1-0.dll
        DLL Name: api-ms-win-crt-math-l1-1-0.dll
        DLL Name: api-ms-win-crt-string-l1-1-0.dll
    ```
    
    After:
    
    ```sh
    $ objdump --all-headers wasmer.dll | rg 'DLL Name'
        DLL Name: bcrypt.dll
        DLL Name: ADVAPI32.dll
        DLL Name: KERNEL32.dll
    ```
    Hywan committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    965aa53 View commit details
    Browse the repository at this point in the history