Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the implementation of shift and rotate. #2155

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Correct the implementation of shift and rotate. #2155

merged 3 commits into from
Mar 2, 2021

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Mar 1, 2021

Fixes #2143.

@nlewycky
Correct implementation of shift and rotate.
c422fde 
The existing implementations worked on x86-64 when instructions were emitted, but relied on UB per the LLVM IR. Add a test which checks the behaviour when the inputs are constants, so that the LLVM IR constant folder can see and exploit the UB.
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Mar 1, 2021
@bors @nlewycky
Merge #2155
5bac44c 
2155: Correct the implementation of shift and rotate. r=syrusakbary a=nlewycky

Fixes #2143.

Co-authored-by: Nick Lewycky <nick@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Mar 1, 2021

Canceled.

@nlewycky
Copy link
Contributor Author

nlewycky commented Mar 1, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 2, 2021

Build succeeded:

@bors bors bot merged commit 3bab215 into master Mar 2, 2021
@bors bors bot deleted the feature/fix-overflow-shift-rotate branch March 2, 2021 00:41
@Hywan Hywan added bug Something isn't working 📦 lib-compiler-llvm About wasmer-compiler-llvm labels Mar 2, 2021
@syrusakbary syrusakbary mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@losfair losfair Awaiting requested review from losfair

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees
No one assigned
Labels
bug Something isn't working 📦 lib-compiler-llvm About wasmer-compiler-llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLVM-compiled Wasm code produces incorrect result
3 participants
@nlewycky @syrusakbary @Hywan