Passive elements and data are now PrimaryMaps

[syrusakbary]

Description

This PR moves some fields in the ModuleInfo to stop using HashMap and start using PrimaryMap as the contents are not sparse but fully dense.
The PR is incentivized by #2180 as it's partially needed to stop using HashMap when possible. It doesn't completely solve it, as the function_names field is still a HashMap, but it should be trivial to solve that in a PR that improves the deserialization time.

Review

• Add a short description of the the change to the CHANGELOG.md file

[MarkMcCaskey]

First of all thanks for the description of what this PR is doing / what it's for.

I'm not sure if I believe that the data here is not sparse. It doesn't start sparse but with elem_drop it looks like it could be become sparse.

Given the diff I've just seen, it looks like the change is correct, but I'm a bit concerned about the change in semantics of this type. There could easily be code not included in this diff which doesn't do the is_empty check and is broken by this change. I think using Option instead of a sentinel value will be less error prone and more explicit. There's no runtime cost to using Option<Box<T>> instead of Box<T>, but the users will now have to deal with a potentially None value, which they were theoretically doing before.

[MarkMcCaskey]

Looks good! the get logic can be cleaned up a bit but otherwise 👍

[syrusakbary]

bors r+

[bors]

Build succeeded:

• Audit
• Code lint
• Test cross-compile on linux
• Test cross-compile on macos
• Test on linux-aarch64
• Test on linux-musl-x64
• Test on linux-x64
• Test on macos-x64
• Test on windows-x64