Remove goblin, use object. #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fuzz/Cargo.toml. For wasm-smith the 'master' git branch was renamed to 'main. Switch to a versioned release since it contains the fixes we need.
syrusakbary
reviewed
May 3, 2021
lib/compiler-llvm/src/object_file.rs
Outdated
| } | ||
| let kind = match (reloc.kind(), reloc.size()) { | ||
| (object::RelocationKind::Absolute, 64) => RelocationKind::Abs8, | ||
| (object::RelocationKind::Elf(24), 0) => RelocationKind::X86PCRel8, |
There was a problem hiding this comment.
Can we have here the proper static variable here instead of 24? (I think the object has defined most of those)
syrusakbary
reviewed
May 3, 2021
nlewycky
force-pushed
the
feature/llvm-remove-goblin
branch
from
52c9b1d
to
3339b76
Compare
Done. |
syrusakbary
approved these changes
May 3, 2021
There's nothing wrong with 0.24 but we have a dependency on 0.23 through 'backtrace' which is used by wasmer-engine, and we'd like to only have one copy.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.