Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused vm::TrapCode variants #2299

Merged
merged 2 commits into from
May 7, 2021
Merged

Remove unused vm::TrapCode variants #2299

merged 2 commits into from
May 7, 2021

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented May 6, 2021 •
edited
Loading

Due to the updated spectests, we no longer precheck during initialization meaning
that this trap can never be thrown

Review

  • Add a short description of the change to the CHANGELOG.md file

Delete TrapCode::HeapSetterOutOfBounds
657a6cd 
Due to the updated spectests, we no longer precheck during initialization meaning
that this trap can never be thrown
Remove TrapCode::TableSetterOutOfBounds
c45b5f8 
This trap code is also now unused due to Wasm spec changes
@MarkMcCaskey MarkMcCaskey changed the title Delete TrapCode::HeapSetterOutOfBounds Remove unused vm::TrapCode variants May 6, 2021
@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 7, 2021

Build succeeded:

@bors bors bot merged commit ac357e4 into master May 7, 2021
@bors bors bot deleted the delete-heapsetteroob branch May 7, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@nlewycky nlewycky Awaiting requested review from nlewycky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @syrusakbary