fix unwrap error when given a no export functions wasm

[chenyukang]

Description

When the wasm file contains no export functions, an unwrap crash will trigger:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', lib/cli/src/commands/run.rs:344:52

This fix will give a more detailed output.

[syrusakbary]

Great catch! Merging!

[syrusakbary]

bors r+

[chenyukang]

I found another issue when adding testcase, my code is not executed when I run:

 cargo test --package wasmer-integration-tests-cli --test run -- run_no_start_wasm_report_error --exact --nocapture

This is because WASMER_PATH only uses the release path, but I run it with debug version.

pub const WASMER_PATH: &str = concat!(
    env!("CARGO_MANIFEST_DIR"),
    "/../../../target/release/wasmer"
);

To keep it consistent, we should fix this:

#[cfg(feature = "debug")]
pub const WASMER_PATH: &str = concat!(
    env!("CARGO_MANIFEST_DIR"),
    "/../../../target/debug/wasmer"
);

#[cfg(not(feature = "debug"))]
pub const WASMER_PATH: &str = concat!(
    env!("CARGO_MANIFEST_DIR"),
    "/../../../target/release/wasmer"
);

@syrusakbary How do you think about it?

[bors]

Canceled.

[syrusakbary]

I think that’s a good change/fix! Happy to merge it on this PR as well

[MarkMcCaskey]

Thanks!

[MarkMcCaskey]

The one thing I'd say, is that the debug feature is not set automatically when doing a debug build... So we may want to have a function which checks for both a debug or release build and uses the newest one? Or a more proper fix, maybe the make test-integration makefile command should depend on build-wasmer so it's always there.

I don't think the debug feature exists in the the integration tests crate, so I think the not(feature = "debug") will be triggered unconditionally

[syrusakbary]

bors r+

[bors]

Build succeeded:

• Audit
• Code lint
• Test cross-compile on linux
• Test cross-compile on macos
• Test on linux-x64
• Test on macos-x64
• Test on windows-x64

[Hywan]

👍 thanks for the PR!