Added Wasmer Js API #2460
Merged
Added Wasmer Js API #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
reviewed
Jul 23, 2021
Comment on lines
+63
to
+66
| #[deprecated( | ||
| since = "2.1.0", | ||
| note = "ModuleInfo, ExportsIterator, ImportsIterator should be imported from wasmer_types." | ||
| )] |
There was a problem hiding this comment.
I'm not sure why we should make it deprecated. It's fine to re-export types from another crate here. What do you think?
Hywan
reviewed
Jul 23, 2021
lib/js-api/src/externals/memory.rs
Outdated
Comment on lines
287
to
294
| pub fn view<T: ValueType>(&self) -> MemoryView<T> { | ||
| unimplemented!("The view function is not yet implemented in Wasmer Javascript"); | ||
| } | ||
|
|
||
| /// example view | ||
| pub fn uint8view(&self) -> js_sys::Uint8Array { | ||
| js_sys::Uint8Array::new(&self.vm_memory.memory.buffer()) | ||
| } |
There was a problem hiding this comment.
uint8view is an example here, not a real method it seems like.
However, we can improve the view method to produce a Uint8Array or simply to provide an ArrayBuffer. We could even mark view as unimplemented, and provide a buffer method. Or just re-use data_ptr to provide an ArrayBuffer.
I think we should try to make view working with ArrayBuffer, that would be the best.
This patch takes the entire `wasmer-js` crate and merges it into the `wasmer` crate. Inside the `lib/api/src/` directory, there are 2 new directories: 1. a new `sys` directory, which contains the usual `wasmer` crate implementation, 2. a new directory `js`, which contains the implementation of `wasmer-js`. The `Cargo.toml` file is still compatible. The `default` feature fallbacks to `sys-default`, which enables the `sys` feature. All features related to compilers or engines or anything else prior this patch, activates the `sys` feature. Parallel to that, there is a `js-default` and `js` features. The `Cargo.toml` file is extensively documented to explain what are dependencies, dev-dependencies, features and other sections related to `sys` or to `js`. There is a bug with `wasm_bindgen_test` where it doesn't compile or look for tests in `tests/*/<test>.rs`. The hack is to name files `tests/js_<test>.rs`. Ugly, but it works.
|
It is possible to merge |
feat(api) Merge `js-api` into `api`
Hywan
approved these changes
Jul 23, 2021
|
bors r+ |
syrusakbary
added
the
🚨 breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for compiling Wasmer into JS/Wasm via wasm-bindgen, so 3rd party dependencies can use Wasmer to target the web also.
Things working:
RuntimeError)Review