-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api,c-api,vm) Move .cargo/config
into crates
#2475
Conversation
bors try |
tryBuild failed: |
I had no idea this was possible. |
Actually I'm not sure it's possible. I may have confused https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies with https://doc.rust-lang.org/cargo/reference/config.html?highlight=rustflags#configuration-format. |
I believe we must write |
Er, we can't configure |
.cargo/config
to Cargo.toml
s.cargo/config
into crates
Reference issue, rust-lang/cargo#9426. |
What we need exactly is rust-lang/cargo#9557: The I'm going to try with |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
Nah, we need to wait :-). |
Should we close this PR @Hywan ? |
We can keep it open and wait on Rust. |
Description
Rework of #1939.
We need to pass the
-Wl,-E
arguments to the linker when compilingwasmer
,wasmer_c_api
andwasmer_vm
. It was done generally with a.cargo/config.toml
file but it was local to our project, i.e. it was not used when Wasmer was a dependency of another project.So we move the content of
.cargo/config.toml
to the respectiveCargo.toml
files.Fixes #1939.
Fixes #1928.
Fixes #2107.
Review
Add a short description of the change to the CHANGELOG.md filenot necessary I guess.