feat(c-api) Create OrderedResolver from a parallel iterator.
#2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds `rayon` to `wasmer-c-api` so that we can create an `OrderedResolver` from a `ParallelIterator`. For modules with a long list of imports, it's interesting to parallelize the work.
|
bors try |
tryBuild failed: |
|
bors try |
syrusakbary
approved these changes
Aug 16, 2021
|
It's approved. I'm not sure how much time we will save from this PR, since generating the exported struct should be fairly fast. Do you have any numbers/insights here @Hywan ? |
|
I don't have a strong number here, the difference is too small and variable :-/. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 17, 2021
2683: Refactor the C API to eliminate memory leaks r=ptitSeb a=Amanieu - Reverted #2521 since it doesn't help performance. - Bumped the minimum Rust version to 1.56 (needed for the macro syntax used). - Fixed memory leaks in the C API examples. - All vector types in the C API now have a proper destructor on the Rust side. - Removed some unnecessary boxing/cloning. Fixes #2469 Fixes #2508 Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds
rayontowasmer-c-apiso that we can create anOrderedResolverfrom aParallelIterator. For modules with a longlist of imports, it's interesting to parallelize the work.
Partially addresses #2506.
Review