Absolute import of Result in derive
#2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Sep 29, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 29, 2021
2587: Absolute import of `Result` in derive r=syrusakbary a=ureeves
# Description
When aliasing `Result` deriving `WasmerEnv` is not possible. See a minimal example of the problem below.
```rust
use wasmer::WasmerEnv;
struct Error;
type Result<T> = core::result::Result<T, Error>;
#[derive(WasmerEnv, Clone)]
struct MyEnv; // error[E0107] this type alias takes 1 generic
// argument but 2 generic arguments were supplied
```
# Review
- [x] Add a short description of the change to the CHANGELOG.md file
Co-authored-by: Eduardo Leegwater Simões <eduardols@protonmail.com>
|
Build failed: |
|
I'm not sure these changes could have caused this @syrusakbary. Anything I can do? |
|
We are aware there are some flaky tests, which seems to be causing the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When aliasing
ResultderivingWasmerEnvis not possible. See a minimal example of the problem below.Review