Partially fix unbounded memory leak from the FuncDataRegistry #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
VMCallerCheckedAnyfuncs for the functions (defined and import) of an instance owned by that instance itself instead of owned by the store-globalFuncDataRegistry. This allows them to be properly freed when the instance is unloaded.Functions used as funcrefs still require an allocation in the
FuncDataRegistry, but this should fix the leak for anyone not using function reference types directly.This also improves instantiation times since we no longer need to grab the global
FuncDataRegisterlock during instantiation.