Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error on some archs by using c_char instead of i8 #2943

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix build error on some archs by using c_char instead of i8 #2943

merged 1 commit into from
Jun 10, 2022

Conversation

silwol
Copy link
Contributor

@silwol silwol commented Jun 9, 2022 •
edited
Loading

Description

Review

  • Add a short description of the change to the CHANGELOG.md file

@silwol silwol force-pushed the silwol/fix-clippy-outfall branch 2 times, most recently from f1eda48 to f550f31 Compare June 9, 2022 19:07
@silwol silwol changed the title Fix failures that appeared with #2942 Fix build error on some archs by using c_char instead of i8 Jun 9, 2022
@syrusakbary
Copy link
Member

How do we know this works? Can we have a test for it?

@ptitSeb
Copy link
Contributor

ptitSeb commented Jun 9, 2022

Is this because char are signed on x86 and unsigned on arm64?

@silwol
Copy link
Contributor Author

silwol commented Jun 9, 2022

Is this because char are signed on x86 and unsigned on arm64?

Exactly. With this change, it uses the c_char directly, independently of the platform it builds on, and therefore inherits whatever type the alias points to.

@ptitSeb ptitSeb self-requested a review June 10, 2022 07:18
@epilys epilys force-pushed the silwol/fix-clippy-outfall branch from f550f31 to fa51a29 Compare June 10, 2022 07:47
@epilys
Copy link
Contributor

epilys commented Jun 10, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 10, 2022

Build succeeded:

@bors bors bot merged commit c9f406c into master Jun 10, 2022
@bors bors bot deleted the silwol/fix-clippy-outfall branch June 10, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silwol @syrusakbary @ptitSeb @epilys