Singlepass nopanic #2966
Merged
Singlepass nopanic #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epilys
approved these changes
Jun 22, 2022
… of panic (but assert are still present)
ptitSeb
force-pushed
the
singlepass_nopanic
branch
from
b8bc406
to
e4b0b71
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed all panic from singlepass compiler, and implemented Result for error handling.
The compiler will now return a CompileError instead of a panic when an opcode is missing or more generalt when something goes wrong in the compiler.
This partly address ticket #2959
Also, tested the compiler performances with the method expalined here: https://wasmer.io/posts/wasmer-2.2 and found no speed change (good job rustc compiler)