Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context capi ci errors #3001

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Fix context capi ci errors #3001

merged 2 commits into from
Jul 2, 2022

Conversation

epilys
Copy link
Contributor

@epilys epilys commented Jul 2, 2022

Some examples/ binaries fail on CI and I didn't notice because on my panopticon macos the binaries weren't allowed to run at all. Fixed them and now all test pass 🎉

@epilys epilys added the 📦 lib-c-api About wasmer-c-api label Jul 2, 2022
@epilys epilys added this to the v3.0 milestone Jul 2, 2022
@epilys epilys requested a review from ptitSeb July 2, 2022 14:26
@epilys epilys requested a review from syrusakbary as a code owner July 2, 2022 14:26
@epilys epilys self-assigned this Jul 2, 2022
@epilys
Copy link
Contributor Author

epilys commented Jul 2, 2022

bors r+

bors bot added a commit that referenced this pull request Jul 2, 2022
@bors @epilys
Merge #3001
cf08f45 
3001: Fix context capi ci errors r=epilys a=epilys

Some `examples/` binaries fail on CI and I didn't notice because on my panopticon macos the binaries weren't allowed to run at all. Fixed them and now all test pass 🎉 

Co-authored-by: Manos Pitsidianakis <manos@wasmer.io>
@epilys
Copy link
Contributor Author

epilys commented Jul 2, 2022

bors cancel

@bors
Copy link
Contributor

bors bot commented Jul 2, 2022

Canceled.

@epilys epilys merged commit aa2055e into context_api Jul 2, 2022
@bors bors bot deleted the fix-context-capi-ci-errors branch July 2, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb Awaiting requested review from ptitSeb

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees

@epilys epilys

Labels
📦 lib-c-api About wasmer-c-api
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@epilys