Merge Backend into EngineBuilder and refactor feature flags #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jul 28, 2022
3047: Improved EngineBuilder API r=epilys a=syrusakbary This PR is a followup from #3046. It basically allows Store being created from anything that can get into `Into<Engine>`, which simplifies greatly the API. It also improves the `EngineBuilder` API, by simplify the `::new` method and making the modifier chain usable when doing `set_target`, `set_features`. The PR also deprecates `Store::new_with_engine` in favor of `Store::new` since `Store::new` can now take `EngineBuilder`, `Engine` and `Box<dyn CompilerConfig>`. Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.