Remove __wbindgen_thread_id #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After talking to John, he mentioned that this function was once implemented in Wasmer, but it isn't implemented anymore, therefore preventing running wasmer-wasi using wasmer itself. Removing this buinding should do absolutely nothing, as it's not used anywhere (anymore).
fschutt
force-pushed
the
remove-useless-c-calls
branch
from
e5feb97
to
2576d28
Compare
syrusakbary
approved these changes
Aug 5, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 5, 2022
3075: Remove __wbindgen_thread_id r=epilys a=fschutt After talking to John, he mentioned that this function was once implemented in Wasmer, but it isn't implemented anymore, therefore preventing running wasmer-wasi using wasmer itself. Removing this buinding should do absolutely nothing, as it's not used anywhere (anymore). # Review - [x] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Felix Schütt <felix@wasmer.io>
epilys
approved these changes
Aug 5, 2022
|
Build failed: |
|
This is going to fail, so merging manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking to John, he mentioned that this function was once implemented in Wasmer, but it isn't implemented anymore, therefore preventing running wasmer-wasi using wasmer itself.
Removing this buinding should do absolutely nothing, as it's not used anywhere (anymore).
Review