Disable wasm build in build CI #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm build was added unnecessarily in the build github action in 4710a2a The wasm build is not currently part of the binary assets of a release, so this commits disable it. By the way, the wasm build fails because the wasm32-wasi target is not added with rustup before the `make build-wasmer-wasm` is called.
|
bors r+ |
|
wasm build was added to avoid it being broken by code change |
|
Build succeeded: |
Makes sense, maybe it'd be better to put it in the test workflows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm build was added unnecessarily in the build github action in
4710a2a
The wasm build is not currently part of the binary assets of a release,
so this commits disable it.
By the way, the wasm build fails because the wasm32-wasi target is
not added with rustup before the
make build-wasmer-wasmis called.