Multithreading, full networking and RPC for WebAssembly #3116

john-sharratt · 2022-08-18T01:03:44Z

Behold! Multithreading, networking and RPC!

…lementations

syrusakbary · 2022-08-18T11:25:49Z

lib/api/src/js/exports.rs

@@ -53,6 +53,9 @@ pub enum ExportError {
    /// This error arises when an export is missing
    #[error("Missing export {0}")]
    Missing(String),
+    /// This error arises when an export is missing
+    #[error("Serialization failed {0}")]
+    SerializationFailed(String),


Not sure if I understand when this can be triggered.
When an export can be missing?

ah this is leftovers - this is not used anymore - we should remove it

syrusakbary · 2022-08-18T11:27:11Z

lib/api/src/js/instance.rs

+        // If the memory is imported then also export it for backwards compatibility reasons
+        // (many will assume the memory is always exported) - later we can remove this
+        if exports.get_memory("memory").is_err() {
+            if let Some(memory) = externs.iter().filter(|a| a.ty(store).memory().is_some()).next() {
+                exports.insert("memory", memory.clone());
+            }
+        }


I really believe we shouldn't do this on the API layer. This should live somewhere else (not on the JS API layer, as it's not JS or VM specific)

that will trigger some increased coding because of these...

But if we are ok to modify the interfaces that assume memory is an export (perhaps we need to put in some form of abstraction) then we can get rid of these.

ptitSeb · 2022-08-22T09:53:07Z

docs/migration_to_3.0.0.md


 ```rust
 let mut wasi_env = WasiState::new("hello").finalize()?;
 let import_object = wasi_env.import_object(&mut store, &module)?;
 let instance = Instance::new(&mut store, &module, &import_object).expect("Could not instantiate module.");
-let memory = instance.exports.get_memory("memory")?;
-wasi_env.data_mut(&mut store).set_memory(memory.clone());
+wasi_env.initialize(&mut store, &instance).unwrap();


Maybe we will want to do this change in the 3.0

yes i think it would be good to bring this forward - i think this way is cleaner

ptitSeb · 2022-08-22T09:56:57Z

lib/api/src/js/function_env.rs

@@ -36,7 +36,7 @@ impl<T> FunctionEnv<T> {
    }

    /// Get the data as reference
-    pub fn as_ref<'a>(&self, store: &'a impl AsStoreMut) -> &'a T
+    pub fn as_ref<'a>(&self, store: &'a impl AsStoreRef) -> &'a T
    where


That could also go to 3.0

yeah this is a easy one to bring in

ptitSeb · 2022-08-22T09:57:26Z

lib/api/src/js/function_env.rs

+    pub fn as_ref(&self) -> FunctionEnv<T> {
+        self.func_env.clone()
+    }
+


And that could go to 3.0 too, I suppose

yeah if we move the other ones we might as well

ptitSeb · 2022-08-22T10:01:54Z

lib/api/src/js/instance.rs

@@ -87,11 +84,11 @@ impl Instance {
    pub fn from_module_and_instance(
        mut store: &mut impl AsStoreMut,
        module: &Module,
+        externs: Vec<Extern>,
        instance: StoreHandle<WebAssembly::Instance>,


That's another API change that should go in 3.0?

not sure on this one as it will drag a bunch of other code with it - might be too much

Does that mean the signature of the function can be rolled back to without the externs, and we forget about this change?

ptitSeb · 2022-08-22T10:03:16Z

lib/api/src/js/module.rs

@@ -152,7 +186,8 @@ impl Module {
    /// Opposed to [`Module::new`], this function is not compatible with
    /// the WebAssembly text format (if the "wat" feature is enabled for
    /// this crate).
-    pub fn from_binary(_store: &impl AsStoreRef, binary: &[u8]) -> Result<Self, CompileError> {
+    pub fn from_binary(_store: &impl AsStoreRef, binary: impl IntoBytes) -> Result<Self, CompileError> {
+        let binary = binary.into_bytes();
        //


and all the IntoBytes changes can also be consider API-breaking changes? (and so should go in 3.0?)

Why we want to own the bytes @john-sharratt ?

In order to pass it between threads - in particular it needs to be shipped to the other WebWorkers in the browser as they can not share the modules between each other, only the compiled bytes can be shared.

ptitSeb · 2022-08-22T10:05:37Z

lib/api/src/sys/function_env.rs

@@ -29,7 +29,7 @@ impl<T> FunctionEnv<T> {
    }

    /// Get the data as reference
-    pub fn as_ref<'a>(&self, store: &'a impl AsStoreMut) -> &'a T
+    pub fn as_ref<'a>(&self, store: &'a impl AsStoreRef) -> &'a T


Should also go in 3.0

ptitSeb · 2022-08-22T10:22:57Z

lib/api/src/sys/instance.rs

+            if let Some(memory) = externs.iter().filter(|a| a.ty(store).memory().is_some()).next() {
+                exports.insert("memory", memory.clone());
+            }
+        }



does this change is also a break-change on the API level?

this probably needs some more thought on it anyway as it assumes the first exported memory but in the future there could be multiple - it does not change the API but does change the behavior.

ptitSeb · 2022-08-22T10:25:01Z

lib/api/src/sys/ptr.rs

@@ -76,7 +76,7 @@ impl<T, M: MemorySize> WasmPtr<T, M> {

    /// Get the offset into Wasm linear memory for this `WasmPtr`.
    #[inline]
-    pub fn offset(self) -> M::Offset {
+    pub fn offset(&self) -> M::Offset {
        self.offset


API breaking change?

API change but i dont think its breaking

syrusakbary · 2022-08-22T11:48:08Z

lib/api/src/js/module.rs

-        _store: &impl AsStoreRef,
-        binary: &[u8],
+        store: &impl AsStoreRef,
+        binary: impl IntoBytes,


Why we want to own the bytes @john-sharratt ?

so the compiled code can be shared to the main thread, compiled there and fed to the other web workers. its a complex setup to get it working because of the JS limitations

if there is an easier way it would be good to drop the Bytes but it is tricky, thats for sure

In the case of JS, the bytes are already stored in Vec<u8>. So it shall be possible to share the compiled code?

syrusakbary · 2022-08-22T11:48:16Z

lib/api/src/js/module.rs

@@ -210,8 +257,9 @@ impl Module {
    /// This validation is normally pretty fast and checks the enabled
    /// WebAssembly features in the Store Engine to assure deterministic
    /// validation of the Module.
-    pub fn validate(_store: &impl AsStoreRef, binary: &[u8]) -> Result<(), CompileError> {
-        let js_bytes = unsafe { Uint8Array::view(binary) };
+    pub fn validate(_store: &impl AsStoreRef, binary: impl IntoBytes) -> Result<(), CompileError> {


Why we want to own the bytes @john-sharratt ?

john-sharratt requested a review from syrusakbary as a code owner August 18, 2022 01:03

john-sharratt changed the title ~~Wasix~~ Behold! Multithreading, networking and RPC for WebAssembly Aug 18, 2022

john-sharratt mentioned this pull request Aug 18, 2022

Implemented multi-threading for both JS and SYS, plus other WASIX implementations #3034

Closed

1 task

john-sharratt changed the title ~~Behold! Multithreading, networking and RPC for WebAssembly~~ Behold! Multithreading, full networking and RPC for WebAssembly Aug 18, 2022

john-sharratt force-pushed the wasix branch 10 times, most recently from c34d4a1 to 680043e Compare August 18, 2022 10:35

john-sharratt added 2 commits August 18, 2022 20:42

Implemented shared memory for Wasmer in preparation for multithreading

301540c

Implemented multi-threading for both JS and SYS, plus other WASIX imp…

b7ab85d

…lementations

john-sharratt force-pushed the wasix branch from 680043e to b7ab85d Compare August 18, 2022 10:43

syrusakbary reviewed Aug 18, 2022

View reviewed changes

epilys changed the title ~~Behold! Multithreading, full networking and RPC for WebAssembly~~ Multithreading, full networking and RPC for WebAssembly Aug 18, 2022

Further improvements in preparation for the deploy release

3809420

ptitSeb reviewed Aug 22, 2022

View reviewed changes

syrusakbary reviewed Aug 22, 2022

View reviewed changes

Added WebC to Deploy

5890423

ptitSeb changed the base branch from master to feat_multithread_network_rpc August 24, 2022 09:15

ptitSeb merged commit d947b95 into wasmerio:feat_multithread_network_rpc Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multithreading, full networking and RPC for WebAssembly #3116

Multithreading, full networking and RPC for WebAssembly #3116

john-sharratt commented Aug 18, 2022

syrusakbary Aug 18, 2022

john-sharratt Aug 19, 2022

syrusakbary Aug 18, 2022 •

edited

Loading

john-sharratt Aug 19, 2022 •

edited

Loading

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 25, 2022

ptitSeb Aug 22, 2022

syrusakbary Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

ptitSeb Aug 22, 2022

john-sharratt Aug 23, 2022

syrusakbary Aug 22, 2022

john-sharratt Aug 23, 2022

john-sharratt Aug 23, 2022

syrusakbary Aug 23, 2022

syrusakbary Aug 22, 2022

john-sharratt Aug 23, 2022

Multithreading, full networking and RPC for WebAssembly #3116

Multithreading, full networking and RPC for WebAssembly #3116

Conversation

john-sharratt commented Aug 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syrusakbary Aug 18, 2022 • edited Loading

Choose a reason for hiding this comment

john-sharratt Aug 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syrusakbary Aug 18, 2022 •

edited

Loading

john-sharratt Aug 19, 2022 •

edited

Loading