Added LinearMemory trait #3119
Merged
Added LinearMemory trait #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Aug 18, 2022
syrusakbary
reviewed
Aug 18, 2022
syrusakbary
reviewed
Aug 18, 2022
|
@ptitSeb can you add tests using a custom memory implementation? |
|
@ptitSeb I think we want the custom memory to be used from the Tunables to make sure the wasmer API is well-rounded so people can use it properly |
syrusakbary
reviewed
Aug 23, 2022
lib/api/src/sys/tunables.rs
Outdated
| _vm_definition_location: NonNull<VMMemoryDefinition>, | ||
| ) -> Result<VMMemory, MemoryError> { | ||
| let memory = VMTinyMemory::new().unwrap(); | ||
| Ok(VMMemory::from_custom(memory)) |
There was a problem hiding this comment.
Can we do Ok(memory.into()) (as I believe the From is implemented)
syrusakbary
reviewed
Aug 23, 2022
syrusakbary
reviewed
Aug 23, 2022
syrusakbary
approved these changes
Aug 23, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LinearMemory trait, to describe memory used in runtime.