Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panics from Artifact::deserialize #3130

Merged
merged 13 commits into from
Aug 25, 2022
Merged

Remove panics from Artifact::deserialize #3130

merged 13 commits into from
Aug 25, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Aug 23, 2022 •
edited
Loading

Fixes #2955

Review

  • Add a short description of the change to the CHANGELOG.md file

@fschutt fschutt requested a review from syrusakbary as a code owner August 23, 2022 11:32
@fschutt fschutt force-pushed the fix-wasmer-cache-panic-2 branch from c0672d2 to e2daf4f Compare August 23, 2022 12:40
@fschutt fschutt changed the title Split Artifact::deserialize into two functions to prevent panics Remove panics from Artifact::deserialize Aug 23, 2022
@syrusakbary
Copy link
Member

Tests are failing, once they pass we should be good to go

@syrusakbary syrusakbary merged commit cfd49c2 into master Aug 25, 2022
@bors bors bot deleted the fix-wasmer-cache-panic-2 branch August 25, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasmer cache can throw panic if cache file has been corrupted
2 participants
@fschutt @syrusakbary