Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The API breaking changes from future WASIX/Network/Threading addition #3141

Merged
merged 6 commits into from
Sep 2, 2022
Merged

The API breaking changes from future WASIX/Network/Threading addition #3141

merged 6 commits into from
Sep 2, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Aug 26, 2022

Description

Some API Changes to prepare for future WASIX/Network/MultiThreading changes.

syrusakbary
syrusakbary requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing two things:

  1. Module::serialize should return Result<Bytes, SerializeError>.
  2. Module.raw_bytes should be stored as Option<Bytes> instead of Option<Vec<u8>>

syrusakbary
syrusakbary reviewed Sep 1, 2022
View reviewed changes
lib/api/src/lib.rs Outdated Show resolved Hide resolved
@syrusakbary syrusakbary merged commit e259738 into master Sep 2, 2022
@bors bors bot deleted the feat_api_change_from_wasix branch September 2, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@john-sharratt john-sharratt Awaiting requested review from john-sharratt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @syrusakbary