Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "create-exe" for windows-x86_64 target #3299

Merged
merged 36 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
26524da
Add integration test for failing create-exe command
fschutt Nov 11, 2022
b63701c
Debug issue on macos
fschutt Nov 11, 2022
6f3b356
Debug issue on MacOS
fschutt Nov 11, 2022
97b1834
Fix target on Linux
fschutt Nov 11, 2022
cb6fda1
Add gcc-multilib package to linux
fschutt Nov 12, 2022
ddf4b33
Try to fix include paths for new wasmer-windows target
fschutt Nov 14, 2022
18765cd
Remove threading when dowloading release to prevent unexpected failure
fschutt Nov 14, 2022
cf77524
Completely rework downloading logic, add -isystem to zig cc
fschutt Nov 15, 2022
b0cee0e
Ignore non- .tar.gz files in cache dir
fschutt Nov 15, 2022
748fe29
Debug why autoinstalling zig isn't working on Windows
fschutt Nov 15, 2022
c6bd018
Debug why create-exe is not downloading Zig on Windows part 2
fschutt Nov 15, 2022
a1c919a
Add unpack_zip to try_unpack_targz
fschutt Nov 15, 2022
852475b
Download .tar.gz files into tempdir instead of path-relative dir
fschutt Nov 15, 2022
2c604e8
Windows: use zig.exe instead of "zig" command
fschutt Nov 15, 2022
e3b317a
Debug why python.obj doesn't get linked correctly
fschutt Nov 15, 2022
f73cf54
Fix cross-compile test by switching to build-exe
fschutt Nov 16, 2022
493f393
Update debug output to debug why create-exe on Windows doesn't output…
fschutt Nov 16, 2022
c60a04c
Add more debug to the zig autoinstallation
fschutt Nov 16, 2022
ec13f47
Remove try_autoinstall_zig function
fschutt Nov 16, 2022
e97118a
Remove windows_underscore specialcase
fschutt Nov 16, 2022
6375a8d
Remove unnecessary configuration
fschutt Nov 16, 2022
aafd57c
Remove unpack zip functionality from unpack_tar_gz
fschutt Nov 16, 2022
0778ddf
Revert renaming wasm.o / wasm.obj differences
fschutt Nov 16, 2022
676e1cc
Revert more .o / .obj renaming
fschutt Nov 16, 2022
a854775
Last .o / .obj renaming
fschutt Nov 16, 2022
87e00f7
Panic in integration test
fschutt Nov 16, 2022
64d4e60
Merge branch 'master' into fix-create-exe-windows
fschutt Nov 18, 2022
9bedc0a
Fix merge issues
fschutt Nov 18, 2022
a81344e
Fix windows-gnu create-exe
fschutt Nov 18, 2022
195ec84
Download -gnu64.tar.gz on Windows, fix make lint
fschutt Nov 18, 2022
a6acb6b
Remove windows target for the -rc.5 release
fschutt Nov 18, 2022
b5d0896
Fix make lint
fschutt Nov 18, 2022
be6f63f
Add zig to integration-tests
fschutt Nov 18, 2022
43c94ff
Merge branch 'master' into fix-create-exe-windows
fschutt Nov 18, 2022
71563bc
Turn error into warning for failing GH API fetch, print response
fschutt Nov 18, 2022
db299b8
Authenticate requests to /release page with GITHUB_TOKEN in CI
fschutt Nov 18, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test-sys.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ jobs:
SCCACHE_AZURE_CONNECTION_STRING: ${{ secrets.SCCACHE_AZURE_CONNECTION_STRING }}
steps:
- uses: actions/checkout@v3
- uses: goto-bus-stop/setup-zig@v2
with:
version: 0.10.0
- name: Set up libstdc++ on Linux
if: matrix.build == 'linux-x64'
run: |
Expand Down Expand Up @@ -211,6 +214,7 @@ jobs:
TARGET_DIR: target/${{ matrix.target }}/release
CARGO_TARGET: --target ${{ matrix.target }}
WAPM_DEV_TOKEN: ${{ secrets.WAPM_DEV_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

#- name: Test integration CLI
# if: matrix.run_test && matrix.os == 'windows-2019'
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ api-docs-repo/
# Generated by tests on Android
/avd
/core
out.txt
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ libc = { version = "^0.2", default-features = false }
nuke-dir = { version = "0.1.0", optional = true }
webc = { version = "3.0.1", optional = true }
isatty = "0.1.9"
tar = "0.4"
dialoguer = "0.10.2"

[build-dependencies]
Expand Down
Loading