Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Module::IoCompileError as it's an error returned by an exported function #3311

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Export Module::IoCompileError as it's an error returned by an exported function #3311

merged 1 commit into from
Nov 16, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Nov 16, 2022

Description

Export Module::IoCompileError as it's an error returned by an exported function (for #3267 )

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner November 16, 2022 11:05
@ptitSeb ptitSeb enabled auto-merge November 16, 2022 19:42
@ptitSeb ptitSeb disabled auto-merge November 16, 2022 23:20
@ptitSeb ptitSeb enabled auto-merge November 16, 2022 23:20
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 16, 2022

bors r+

bors bot added a commit that referenced this pull request Nov 16, 2022
@bors @ptitSeb
Merge #3311
4f62660 
3311: Export Module::IoCompileError as it's an error returned by an exported function r=ptitSeb a=ptitSeb

# Description
Export Module::IoCompileError as it's an error returned by an exported function (for #3267 )

Co-authored-by: ptitSeb <sebastien.chev@gmail.com>
@ptitSeb ptitSeb merged commit 0d5e7d9 into master Nov 16, 2022
@ptitSeb ptitSeb deleted the fix_export_iocompileerror branch November 16, 2022 23:28
@bors
Copy link
Contributor

bors bot commented Nov 16, 2022

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

@fschutt fschutt mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @syrusakbary