Remove wasi conditional compilation from wasmer-registry #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wasmer-registrycrate can't compile to WASI at the moment becausewasm-bus(used bywasm-bus-reqwest) is broken, and WASI doesn't support networking even if the crate compiled. I'm removing the code hidden behind#[cfg(target_os = "wasi")]because it's dead code at the moment.I've also removed the conditional compilation for
feature = "telemetry"andfeature = "update-notifications"because this crate doesn't actually have any features. I think it should be fine to include those fields all the time because they are part of the config format, and let upstream (i.e.wasmer-cli) decide whether it wants to enable code for telemetry and undate notifications.