Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create-exe to be able to cross-compile on Windows #3395

Merged
merged 15 commits into from
Dec 2, 2022
Merged

Fix create-exe to be able to cross-compile on Windows #3395

merged 15 commits into from
Dec 2, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Nov 30, 2022

Fixes #3374.

@fschutt fschutt requested a review from syrusakbary as a code owner November 30, 2022 19:14
@fschutt fschutt marked this pull request as draft December 1, 2022 11:36
@fschutt fschutt marked this pull request as ready for review December 1, 2022 18:50
Michael-F-Bryan
Michael-F-Bryan reviewed Dec 1, 2022
View reviewed changes
lib/cli/src/commands/create_exe.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/create_exe.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/create_exe.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/create_exe.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/create_exe.rs Outdated Show resolved Hide resolved
theduke
theduke reviewed Dec 2, 2022
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not terribly familiar with this, but just two small questions, otherwise LGTM.

lib/cli/src/commands/create_exe.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/create_exe.rs Show resolved Hide resolved
theduke
theduke approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ASSSUMING that we don't want the stripping anymore, otherwise it should be added back in before merging.

lib/cli/src/commands/create_exe.rs Show resolved Hide resolved
@fschutt
Copy link
Contributor Author

fschutt commented Dec 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Build succeeded:

  • Code lint

@bors bors bot merged commit b3ea89b into master Dec 2, 2022
@bors bors bot deleted the fix-create-exe branch December 2, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan left review comments

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with create-exe on Windows 11
3 participants
@fschutt @theduke @Michael-F-Bryan