Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasm_importtype_copy to C API #3403

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Add wasm_importtype_copy to C API #3403

merged 1 commit into from
Dec 2, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Dec 2, 2022

Fixes #3322.

@Pangoraw @fschutt
implement wasm_importtype_copy
88ec6ed 
Signed-off-by: Felix Schütt <felix@wasmer.io>
@fschutt
Copy link
Contributor Author

fschutt commented Dec 2, 2022

I tested manually that it works, I don't think we need a unit / integration test here.

Before:

$ nm target/release/libwasmer.so | grep wasm_importtype_copy
$

After:

$ nm target/release/libwasmer.so | grep wasm_importtype_copy
00000000000d6248 T _wasm_importtype_copy
$

@fschutt
Copy link
Contributor Author

fschutt commented Dec 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Build succeeded:

@bors bors bot merged commit ef8d2f6 into master Dec 2, 2022
@bors bors bot deleted the fix-3322 branch December 2, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[c-api] could not load symbol "wasm_importtype_copy":
3 participants
@fschutt @Michael-F-Bryan @Pangoraw