Module.deserialize - accept AsEngineRef

[dsherret]

I need this in order to use this code #3378 (comment) with Module::deserialize instead.

[syrusakbary]

Thanks @dsherret, the CI error seems unrelated to your changes.
But could be possible to update also the wasmer-cache crate to use as well the AsEngineRef? Thanks!

[dsherret]

@syrusakbary I looked into it just now. It would require updating the Cache trait, which would be a breaking change. Is that ok?

[syrusakbary]

It would require updating the Cache trait, which would be a breaking change. Is that ok?

Yes, that should be ok @dsherret. Thanks for double checking though!

[dsherret]

Should be good now I think.

[syrusakbary]

Looks good. We have some issue in master that prevented tests to pass.
I updated the branch but tests should be passing soon!

[syrusakbary]

Still failing but it's independent on this PR

[theduke]

@syrusakbary

Note: this breaks existing code.

Concretely, a value with type &impl AsStoreRef is not acceptect anymore.

(this is on the wasix branch)

error[E0277]: the trait bound `impl AsStoreRef: AsEngineRef` is not satisfied
   --> lib/wasi/src/bin_factory/module_cache.rs:201:39
    |
201 |                 let module = unsafe { Module::deserialize(store, &module_bytes[..]).unwrap() };
    |                                       ^^^^^^^^^^^^^^^^^^^ the trait `AsEngineRef` is not implemented for `impl AsStoreRef`
    |
note: required by a bound in `wasmer::Module::deserialize`
   --> /home/theduke/dev/github.com/wasmerio/wasmer/lib/api/src/sys/module.rs:270:23
    |
270 |         engine: &impl AsEngineRef,
    |                       ^^^^^^^^^^^ required by this bound in `wasmer::Module::deserialize`
help: consider further restricting this bound
    |
163 |         store: &impl AsStoreRef + wasmer::AsEngineRef,
    |                                 +++++++++++++++++++++

    pub fn get_compiled_module(
        &self,
        store: &impl AsStoreRef,
        data_hash: &str,
        compiler: &str,
    ) -> Option<Module> {
    ...
     Module::deserialize(store, &module_bytes[..]).
    }