Internal runtime ↔️ backend abstraction refactor. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the ProtectedCaller and FuncResolver traits, simplifying call implementations and improving dynamic call throughput.
|
bors try |
|
bors try |
tryBuild failed |
|
bors try |
bjfish
approved these changes
Apr 17, 2019
|
thank you @bjfish bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 17, 2019
348: Internal runtime↔️ backend abstraction refactor. r=lachlansneff a=lachlansneff This replaces the `ProtectedCaller` and `FuncResolver` traits with a combined `RunnableModule` trait. I'd like to get this merged, since it's standalone, but there are follow-up PRs I'd like to make that will further change the abstraction Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com> Co-authored-by: Syrus Akbary <me@syrusakbary.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
ProtectedCallerandFuncResolvertraits with a combinedRunnableModuletrait. I'd like to get this merged, since it's standalone, but there are follow-up PRs I'd like to make that will further change the abstraction