Fix small return types. #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed |
|
bors try |
syrusakbary
approved these changes
Apr 22, 2019
|
It works on Linux, @xmclark will test on Windows |
MarkMcCaskey
suggested changes
Apr 22, 2019
| pub const __WASI_ETIMEDOUT: u16 = 73; | ||
| pub const __WASI_ETXTBSY: u16 = 74; | ||
| pub const __WASI_EXDEV: u16 = 75; | ||
| pub const __WASI_ENOTCAPABLE: u16 = 76; |
There was a problem hiding this comment.
We should revert everything else. The fix changed all u16s to u32s
… errors from imported functions" This reverts commit 74b6ba4. # Conflicts: # lib/wasi/src/syscalls/mod.rs
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 22, 2019
379: Fix small return types. r=syrusakbary a=lachlansneff This fixes returning integers smaller than 32bits from imported functions. Also some work on fixing returning errors from functions. Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com> Co-authored-by: Syrus <me@syrusakbary.com>
MarkMcCaskey
approved these changes
Apr 22, 2019
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Apr 22, 2019
379: Fix small return types. r=syrusakbary a=lachlansneff This fixes returning integers smaller than 32bits from imported functions. Also some work on fixing returning errors from functions. Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com> Co-authored-by: Syrus <me@syrusakbary.com>
|
bors r+ |
|
Already running a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes returning integers smaller than 32bits from imported functions. Also some work on fixing returning errors from functions.