Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extending WASI plugin example #399

Merged
merged 14 commits into from
Apr 29, 2019
Merged

Add extending WASI plugin example #399

merged 14 commits into from
Apr 29, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

No description provided.

@xmclark xmclark self-requested a review April 29, 2019 15:09
xmclark
xmclark suggested changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! This was needed.

I made some feedback. The only other suggestion is adding a wapm.toml. We may not publish it, but it is still good for people to see wapm in the wild ™️ .

examples/plugin-for-example/README.md Outdated Show resolved Hide resolved
examples/plugin-for-example/README.md Outdated Show resolved Hide resolved
examples/plugin-for-example/README.md
# build it
cargo build --release --target=wasm32-unknown-wasi
# copy it to examples folder
cp ../../target/wasm32-unknown-wasi/release/plugin-for-example.wasm ../
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may also be worth noting that WASI is only supported on windows with the gnu toolchain. If you can't find a way to work this detail into the example, that's ok, but it could be another stumbling block for some.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm not sure exactly what to add to say that. What I mean is, does that show up in the target dir?

examples/plugin.rs Outdated Show resolved Hide resolved
examples/plugin-for-example/Cargo.toml Show resolved Hide resolved
examples/plugin.rs Show resolved Hide resolved
examples/plugin.rs Show resolved Hide resolved
examples/plugin.rs Show resolved Hide resolved
xmclark and others added 7 commits April 29, 2019 08:30
@xmclark
Merge branch 'master' into feature/extending-wasi-plugin-example
7e38664
@xmclark @MarkMcCaskey
Update examples/plugin.rs
0add458 
Co-Authored-By: MarkMcCaskey <MarkMcCaskey@users.noreply.github.com>
@xmclark @MarkMcCaskey
Update examples/plugin.rs
bc0289c 
Co-Authored-By: MarkMcCaskey <MarkMcCaskey@users.noreply.github.com>
@xmclark @MarkMcCaskey
Update examples/plugin.rs
8e9767c 
Co-Authored-By: MarkMcCaskey <MarkMcCaskey@users.noreply.github.com>
update from feedback
4f4473c
Merge branch 'feature/extending-wasi-plugin-example' of github.com:wa…
c48171c 
…smerio/wasmer into feature/extending-wasi-plugin-example
add comment; add wapm.toml
0f22a51
@xmclark xmclark self-requested a review April 29, 2019 18:34
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 29, 2019
@bors @MarkMcCaskey @xmclark
Merge #399
7ad4228 
399: Add extending WASI plugin example r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Co-authored-by: Mackenzie Clark <mackenzie.a.z.c@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 29, 2019

Build succeeded

@bors bors bot merged commit 49aa104 into master Apr 29, 2019
@bors bors bot deleted the feature/extending-wasi-plugin-example branch April 29, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @xmclark