Use cargo nextest when running tests in CI
#4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arshia001
approved these changes
Sep 27, 2023
ptitSeb
approved these changes
Sep 27, 2023
theduke
approved these changes
Sep 27, 2023
Michael-F-Bryan
force-pushed
the
nextest
branch
2 times, most recently
from
e15a69f
to
76ad310
Compare
Michael-F-Bryan
force-pushed
the
nextest
branch
from
bf72293
to
54c6a08
Compare
Michael-F-Bryan
force-pushed
the
nextest
branch
from
54c6a08
to
cbe6979
Compare
added 6 commits
December 8, 2023 15:17
Michael-F-Bryan
force-pushed
the
nextest
branch
from
cbe6979
to
bbe7246
Compare
|
@syrusakbary this PR is ready to merge. We just need to remove the requirement for "Build and Test (wasmer-web)" to pass because that CI job has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a well-known problem that Wasmer contains many flaky tests, and it's not uncommon to need to restart a CI run 2 or 3 times before tests will pass. For example, this CI run from #4224 took 5 restarts before all the
create-exetests would pass.This PR switches from
cargo testtocargo nextestand enables automatic retries for some known flaky tests. I've deliberately not added a blanketretries = 3because this lets us track roughly which tests are flaky. The intention is that if you are working on a PR and notice a flaky test, you'll explicitly add it to the set of overrides in.config/nextest.toml.This won't fix issues like
note: /usr/bin/ld: final link failed: No space left on devicewhen our cache grows so big it fills up the disk, but hopefully it'll help mask the flakiness a bit better.