Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file metadata wasi test #457

Merged
merged 12 commits into from
May 20, 2019
Merged

fix file metadata wasi test #457

merged 12 commits into from
May 20, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented May 20, 2019 •
edited
Loading

gets the test working by properly filling in data into the stat

also resolves #453

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label May 20, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
82f496a
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
085fdcc
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
c3b4e20
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
94d4128
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
f34cb31
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build failed

@MarkMcCaskey MarkMcCaskey mentioned this pull request May 20, 2019
Closed
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
1f9023c
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 20, 2019
@bors
Try #457:
e8d3575
syrusakbary
syrusakbary approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request May 20, 2019
@bors @MarkMcCaskey
Merge #457
082c56b 
457: fix file metadata wasi test r=MarkMcCaskey a=MarkMcCaskey

gets the test working by properly filling in data into the stat

also resolves #453 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented May 20, 2019

try

Build succeeded

@bors
Copy link
Contributor

bors bot commented May 20, 2019

Build succeeded

@bors bors bot merged commit f2001fe into master May 20, 2019
@bors bors bot deleted the fix/wasi-fs-metadata-test branch May 20, 2019 22:21
@bjorn3
Copy link

bjorn3 commented May 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time going backwards???
3 participants
@MarkMcCaskey @bjorn3 @syrusakbary