Prevent parent directory from being opened without being preopened wasi #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
May 22, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 22, 2019
463: Prevent parent directory from being opened without being preopened wasi r=MarkMcCaskey a=MarkMcCaskey resolves #462 Because the logic of opening a directory and traversing the tree are separate, we allowed one level of `..` to be opened beyond what was preopened The diff on github isn't clear, but this adds an if and then puts the previous logic in an else block Co-authored-by: Mark McCaskey <mark@wasmer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #462
Because the logic of opening a directory and traversing the tree are separate, we allowed one level of
..to be opened beyond what was preopenedThe diff on github isn't clear, but this adds an if and then puts the previous logic in an else block