Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stack offset check #486

Closed
wants to merge 2 commits into from
Closed

fix stack offset check #486

wants to merge 2 commits into from

Conversation

laizy
Copy link
Contributor

@laizy laizy commented Jun 8, 2019

note: I have not read the whole code yet, so I might be wrong.

@syrusakbary
Copy link
Member

Thanks for contributing @laizy.

I think it will very useful to add a test case verifying the fix, so we assure it doesn't repeat in the future.
If you can add it to this PR it would be great!

@losfair losfair mentioned this pull request Jun 8, 2019
Merged
@losfair
Copy link
Contributor

losfair commented Jun 8, 2019

Thanks!

I've added a WASM test case for this and fixed a typo. The new PR is #487 .

bors bot added a commit that referenced this pull request Jun 8, 2019
@bors @laizy @losfair
Merge #487
d5dbabf 
487: Fix stack offset check in singlepass backend. r=losfair a=losfair

#486 

Co-authored-by: laizy <aochyi@126.com>
Co-authored-by: losfair <zhy20000919@hotmail.com>
@laizy laizy closed this Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laizy @syrusakbary @losfair