Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to newer cranelift and wasmparser 0.32.1. #518

Merged
merged 7 commits into from
Jul 2, 2019
Merged

Update to newer cranelift and wasmparser 0.32.1. #518

merged 7 commits into from
Jul 2, 2019

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Jul 1, 2019

No description provided.

syrusakbary
syrusakbary approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nlewycky
Copy link
Contributor Author

nlewycky commented Jul 1, 2019

bors try

bors bot added a commit that referenced this pull request Jul 1, 2019
@bors
Try #518:
c6194d2
@bors
Copy link
Contributor

bors bot commented Jul 1, 2019

try

Build failed

@Hywan
Copy link
Contributor

Hywan commented Jul 2, 2019

I'm surprised Dependabot didn't open a PR for us 🤔.

@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-compiler-cranelift About wasmer-compiler-cranelift labels Jul 2, 2019
@nlewycky nlewycky changed the title Update to newer cranelift which also requires an update to wasmparser 0.31.0. Update to newer cranelift which also requires an update to wasmparser 0.32.1. Jul 2, 2019
@nlewycky nlewycky changed the title Update to newer cranelift which also requires an update to wasmparser 0.32.1. Update to newer cranelift and wasmparser 0.32.1. Jul 2, 2019
@nlewycky
Copy link
Contributor Author

nlewycky commented Jul 2, 2019

bors try

bors bot added a commit that referenced this pull request Jul 2, 2019
@bors
Try #518:
d521183
@bors
Copy link
Contributor

bors bot commented Jul 2, 2019

try

Build succeeded

@nlewycky
Copy link
Contributor Author

nlewycky commented Jul 2, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 2, 2019
@bors @nlewycky
Merge #518
92f1aa7 
518: Update to newer cranelift and wasmparser 0.32.1. r=nlewycky a=nlewycky



Co-authored-by: Nick Lewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Jul 2, 2019

Build succeeded

@bors bors bot merged commit edb674d into master Jul 2, 2019
@bors bors bot deleted the update-cranelift branch July 2, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-compiler-cranelift About wasmer-compiler-cranelift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlewycky @Hywan @syrusakbary