Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi filesystem rewrite + implementation of many syscalls #555

Merged
merged 15 commits into from
Jul 19, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Jul 12, 2019

This lets the go compiler print its help text...

The rest of symlink code to follow...

This PR also does a major refactor of the file system code. So we'll have to add more tests to be sure we didn't break anything

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label Jul 12, 2019
@MarkMcCaskey MarkMcCaskey changed the title implement wasi::readlink wasi filesystem rewrite + implementation of many syscalls Jul 19, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 19, 2019
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than small nits it looks great.
I was not able to come with other new tests cases that will help on coverage

@bors

This comment has been minimized.

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jul 19, 2019
555: wasi filesystem rewrite + implementation of many syscalls r=MarkMcCaskey a=MarkMcCaskey

This lets the go compiler print its help text...

The rest of symlink code to follow...

This PR also does a major refactor of the file system code.  So we'll have to add more tests to be sure we didn't break anything

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jul 19, 2019

@bors bors bot merged commit 04b540c into master Jul 19, 2019
@bors bors bot deleted the feature/wasi-readlink branch July 19, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants