fix Drop of uninit Ctx; use MaybeUninit #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewycky
approved these changes
Jul 24, 2019
losfair
approved these changes
Jul 24, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
576: fix Drop of uninit Ctx; use MaybeUninit r=MarkMcCaskey a=MarkMcCaskey I'm somewhat concerned that we need to call `intrinsics::panic_if_uninhabited::<T>();` or something to tell the compiler that we know it's safe. We just reinterpret the pointer later as initialized which is safe in theory due to `repr(transparent)` this should unblock #561 Co-authored-by: Mark McCaskey <mark@wasmer.io>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
576: fix Drop of uninit Ctx; use MaybeUninit r=MarkMcCaskey a=MarkMcCaskey I'm somewhat concerned that we need to call `intrinsics::panic_if_uninhabited::<T>();` or something to tell the compiler that we know it's safe. We just reinterpret the pointer later as initialized which is safe in theory due to `repr(transparent)` this should unblock #561 Co-authored-by: Mark McCaskey <mark@wasmer.io>
bjfish
approved these changes
Jul 24, 2019
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
576: fix Drop of uninit Ctx; use MaybeUninit r=MarkMcCaskey a=MarkMcCaskey I'm somewhat concerned that we need to call `intrinsics::panic_if_uninhabited::<T>();` or something to tell the compiler that we know it's safe. We just reinterpret the pointer later as initialized which is safe in theory due to `repr(transparent)` this should unblock #561 Co-authored-by: Mark McCaskey <mark@wasmer.io>
Timed out |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
576: fix Drop of uninit Ctx; use MaybeUninit r=MarkMcCaskey a=MarkMcCaskey I'm somewhat concerned that we need to call `intrinsics::panic_if_uninhabited::<T>();` or something to tell the compiler that we know it's safe. We just reinterpret the pointer later as initialized which is safe in theory due to `repr(transparent)` this should unblock #561 Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
added 2 commits
July 24, 2019 13:49
…to fix/dropping-bad-data
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 24, 2019
576: fix Drop of uninit Ctx; use MaybeUninit r=MarkMcCaskey a=MarkMcCaskey I'm somewhat concerned that we need to call `intrinsics::panic_if_uninhabited::<T>();` or something to tell the compiler that we know it's safe. We just reinterpret the pointer later as initialized which is safe in theory due to `repr(transparent)` this should unblock #561 Co-authored-by: Mark McCaskey <mark@wasmer.io> Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
YaronWittenstein
added a commit
to spacemeshos/svm
that referenced
this pull request
Jul 25, 2019
the specific wasmer fix-issue: [fix Drop of uninit Ctx; use MaybeUninit](wasmerio/wasmer#576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm somewhat concerned that we need to call
intrinsics::panic_if_uninhabited::<T>();or something to tell the compiler that we know it's safe.We just reinterpret the pointer later as initialized which is safe in theory due to
repr(transparent)this should unblock #561