Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for closing wasi preopen fd #776

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Add test for closing wasi preopen fd #776

merged 2 commits into from
Sep 12, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

As discussed in WASI, we should be able to close preopen fds

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label Sep 11, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 11, 2019
@bors
Try #776:
fbedd13
@MarkMcCaskey
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 11, 2019

try

Already running a review

@MarkMcCaskey
Copy link
Contributor Author

bors try-

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 11, 2019
@bors
Try #776:
119366b
@bors
Copy link
Contributor

bors bot commented Sep 11, 2019

try

Build succeeded

  • wasmerio.wasmer

nlewycky
nlewycky approved these changes Sep 11, 2019
View reviewed changes
lib/wasi/src/state/mod.rs Outdated
// calling `path_open` can give you an fd to the same inode as a preopen fd
entries.remove(&key);
self.preopen_fds.remove(i);
// Maybe recursively closes fds if og preopen?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"og"?

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Sep 11, 2019
@bors
Merge #776
2a5a647 
776: Add test for closing wasi preopen fd r=MarkMcCaskey a=MarkMcCaskey

As discussed in WASI, we should be able to close preopen fds

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Sep 12, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit 35ee83d into master Sep 12, 2019
@bors bors bot deleted the feature/wasi-close-preopen-fd branch September 12, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewycky nlewycky nlewycky approved these changes

Assignees
No one assigned
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @nlewycky